----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/132/ -----------------------------------------------------------
(Updated 2010-06-08 10:05:23.389892) Review request for hbase. Changes ------- New version with the fix in LocalHBaseCluster.java (thanks Jonathan for catching this!) + rebased on top of trunk. Summary ------- HBASE-2618 Don't inherit from HConstants. Bonus: minor aesthetic / coding style clean ups and minor code changes. This addresses bug HBASE-2618. Diffs (updated) ----- trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/HMerge.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/master/RegionServerOperation.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/master/TableOperation.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java 952565 trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 952565 trunk/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 952565 trunk/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java 952565 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java 952565 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java 952565 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetDeleteTracker.java 952565 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueHeap.java 952565 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestQueryMatcher.java 952565 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDeleteTracker.java 952565 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestWildcardColumnTracker.java 952565 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 952565 Diff: http://review.hbase.org/r/132/diff Testing ------- Code compiles. Tests are acting up on my machine right now (many of them fail with a weird message [1] and Todd says he's been seeing similar failures for some time already, so I guess I'll try to run them again next week when the New Moon arrives). [1] A number of tests fail with: org.apache.hadoop.hbase.client.NoServerForRegionException: Timed out trying to locate root region because: Failed setting up proxy to /192.168.0.7:63773 after attempts=1 at org.apache.hadoop.hbase.client.HConnectionManager$TableServers.locateRootRegion(HConnectionManager.java:1031) Where, of course, 192.168.0.7 is my IP address. Some of the tests that are acting up: org.apache.hadoop.hbase.TestZooKeeper, org.apache.hadoop.hbase.regionserver.wal.TestLogRolling, org.apache.hadoop.hbase.rest.TestScannersWithFilters, org.apache.hadoop.hbase.master.TestMasterWrongRS, org.apache.hadoop.hbase.thrift.TestThriftServer, org.apache.hadoop.hbase.master.TestMasterTransitions, org.apache.hadoop.hbase.rest.TestStatusResource, org.apache.hadoop.hbase.client.TestFromClientSide, org.apache.hadoop.hbase.TestMultiParallelPut, org.apache.hadoop.hbase.master.TestRegionManager, org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed Thanks, Benoit
