> On 2010-06-08 14:40:49, stack wrote: > > /trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterWrongRS.java, > > line 71 > > <http://review.hbase.org/r/163/diff/2/?file=1096#file1096line71> > > > > This looks wrong. Shouldn't the index be '1' for the second server? > > Its the index you used at start of the test to get reference to seconServer. > > > > Otherwise, looks good.. go ahead and commit
After chatting with Stack and looking at the code, it appears I'm actually doing the right thing (he had another method in mind that did not remove the region server from the list). - Jean-Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/163/#review158 ----------------------------------------------------------- On 2010-06-08 14:27:28, Jean-Daniel Cryans wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/163/ > ----------------------------------------------------------- > > (Updated 2010-06-08 14:27:28) > > > Review request for hbase. > > > Summary > ------- > > Patch that uses MiniHBaseCluster.waitOnRegionServer instead of sleeping, and > adds a timeout to the test. > > > This addresses bug HBASE-2684. > > > Diffs > ----- > > /trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterWrongRS.java > 952744 > > Diff: http://review.hbase.org/r/163/diff > > > Testing > ------- > > > Thanks, > > Jean-Daniel > >
