> On 2010-06-06 10:23:33, Andrew Purtell wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro, line 181 > > <http://review.hbase.org/r/128/diff/1/?file=979#file979line181> > > > > No support for filters. For REST, the model classes recursively walk > > the filter structure and build a JSON representation that is then passed as > > a string. > > > > No support for setBatch() > > > > Consider support for setCacheBlocks() (regionserver level caching) and > > setCaching() (connector level caching)? > > Jeff Hammerbacher wrote: > https://issues.apache.org/jira/browse/HBASE-2690 is for the caching and > https://issues.apache.org/jira/browse/HBASE-2687 is for the filters. Thanks > for letting me know how you did things in the REST interface; I'll try to > mimic your approach. I held off on implementing because I wasn't quite sure > what the API would look like.
Doesn't make sense with my current Scan API (super simple: table + number of rows). I filed https://issues.apache.org/jira/browse/HBASE-2705 to take care of this one at a later date. > On 2010-06-06 10:23:33, Andrew Purtell wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java, line 386 > > <http://review.hbase.org/r/128/diff/1/?file=950#file950line386> > > > > Export exists() to the client. Done > On 2010-06-06 10:23:33, Andrew Purtell wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java, line 335 > > <http://review.hbase.org/r/128/diff/1/?file=950#file950line335> > > > > No split()? Done > On 2010-06-06 10:23:33, Andrew Purtell wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java, line 324 > > <http://review.hbase.org/r/128/diff/1/?file=950#file950line324> > > > > That would be good. Removed comment; this will work with region names as well. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/128/#review138 ----------------------------------------------------------- On 2010-06-05 23:16:10, Jeff Hammerbacher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/128/ > ----------------------------------------------------------- > > (Updated 2010-06-05 23:16:10) > > > Review request for hbase. > > > Summary > ------- > > Initial patch; some javadoc and tests missing, but I wanted to get some > initial feedback on the approach. My apologies for sticking a patch on the > JIRA before the review. I should have read further on the HowToContribute > JIRA. > > > This addresses bug HBASE-2400. > > > Diffs > ----- > > trunk/bin/hbase 951826 > trunk/pom.xml 951826 > trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AAlreadyExists.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AClusterStatus.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AColumn.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AColumnFamilyDescriptor.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AColumnValue.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ACompressionAlgorithm.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ADelete.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AFamilyDescriptor.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AGet.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AIOError.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AIllegalArgument.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AMasterNotRunning.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/APut.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ARegionLoad.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AResult.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AResultEntry.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AScan.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AServerAddress.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AServerInfo.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/AServerLoad.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ATableDescriptor.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ATableExists.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/ATimeRange.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/HBase.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/IOError.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/generated/TCell.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.avpr PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/avro/package.html PRE-CREATION > trunk/src/test/java/org/apache/hadoop/hbase/avro/TestAvroServer.java > PRE-CREATION > > Diff: http://review.hbase.org/r/128/diff > > > Testing > ------- > > > Thanks, > > Jeff > >
