----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/185/#review236 -----------------------------------------------------------
/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.hbase.org/r/185/#comment1067> This looks like its needed but I took a look at getZKClusterKey. Should we make sure there are no spaces in the ZOOKEEPER_QUORUM value? Also, what happens if ensemble is made up of 3 members in one config and 5 in another, is that a different zk ensemble? Is ZK_ZNODE_PARENT where this cluster is homed up in the ensemble? Why have the HCM class name in the wrapper name? (I notice why later but why have class name one time and then hostname and port another and then encoded name -- I think -- elsewhere?) /trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java <http://review.hbase.org/r/185/#comment1068> Why this defined in here when its over in HConstants or in HRegion.. don't remember which. /trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java <http://review.hbase.org/r/185/#comment1069> Should this be the master address as you have over inside the HRS where you use servername where master address is hostname + port for case of multiple masters, even in same JVM? /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.hbase.org/r/185/#comment1070> Good /trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java <http://review.hbase.org/r/185/#comment1071> Don't you have a '-' above in HCM rather than a ','. /trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java <http://review.hbase.org/r/185/#comment1072> Ain't this duplicated code from the method just above - in getInstance? /trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java <http://review.hbase.org/r/185/#comment1073> Can this throw session expired? /trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java <http://review.hbase.org/r/185/#comment1074> Here too? - stack On 2010-06-15 18:25:01, Jean-Daniel Cryans wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/185/ > ----------------------------------------------------------- > > (Updated 2010-06-15 18:25:01) > > > Review request for hbase. > > > Summary > ------- > > This patch adds the listZnodes version that takes a watcher and changes the > way the ZKW works to include the notion of multiple clusters in the same JVM. > > > This addresses bug HBASE-2735. > http://issues.apache.org/jira/browse/HBASE-2735 > > > Diffs > ----- > > /trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 955103 > /trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 955103 > /trunk/src/main/java/org/apache/hadoop/hbase/master/ProcessRegionOpen.java > 955103 > /trunk/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java > 955103 > > /trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java > 955103 > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 955103 > > /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RSZookeeperUpdater.java > 955103 > > /trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java > 955103 > /trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java > 955103 > /trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java 955103 > > Diff: http://review.hbase.org/r/185/diff > > > Testing > ------- > > > Thanks, > > Jean-Daniel > >
