----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/191/#review248 -----------------------------------------------------------
src/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java <http://review.hbase.org/r/191/#comment1096> I presume we go to use this heap later in this method? If so, could it be null then? Can another method be clearing this.heap outside of a synchronization? src/test/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java <http://review.hbase.org/r/191/#comment1097> Why does this test for the NPE? Why all the gratuitous changes above this change? - stack On 2010-06-16 17:22:31, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/191/ > ----------------------------------------------------------- > > (Updated 2010-06-16 17:22:31) > > > Review request for hbase and stack. > > > Summary > ------- > > HBASE-2740 NPE in ReadWriteConsistencyControl > > > Diffs > ----- > > src/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 6d4546f > src/test/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java 76ab7b5 > > Diff: http://review.hbase.org/r/191/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
