----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/216/ -----------------------------------------------------------
Review request for hbase, stack and Ryan Rawson. Summary ------- Fixes bugs where an exception in the middle of flushing a file leaves a half-written StoreFile in the region dir, preventing that region from recovering, or, in the case of transient errors, causing silent loss of half a file's worth of data. I also got rid of the compaction dir here, and am just using one region-wide tmp dir. Is there some reason this is a bad idea? This addresses bug HBASE-2729. http://issues.apache.org/jira/browse/HBASE-2729 Diffs ----- src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 1794df8 src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 04b7522 src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java 9e5ca46 src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java a65e947 Diff: http://review.hbase.org/r/216/diff Testing ------- Ran TestCompaction and TestStore. Will start a cluster test running before I go to bed. Thanks, Todd