----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/182/ -----------------------------------------------------------
(Updated 2010-06-25 16:30:01.757687) Review request for hbase and stack. Summary ------- Refactor StoreFile and StoreFileScanner and normalize the code to the structure we want. More work left to push KeyValue up to Store left. Diffs ----- src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java 6b58766 src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java ce1c240 src/main/java/org/apache/hadoop/hbase/io/hfile/HFileScanner.java f5a5dc0 src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java 4212efa src/main/java/org/apache/hadoop/hbase/regionserver/MinorCompactingStoreScanner.java 71f738e src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1a604da src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 05826f5 src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java 3541b3b src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java 7680a22 src/main/java/org/apache/hadoop/hbase/util/BloomFilter.java 42e816a src/main/java/org/apache/hadoop/hbase/util/ByteBloomFilter.java c6bb358 src/main/java/org/apache/hadoop/hbase/util/DynamicByteBloomFilter.java f818279 src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java e65ae34 Diff: http://review.hbase.org/r/182/diff Testing ------- Thanks, Ryan