----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/240/#review292 -----------------------------------------------------------
Ship it! Ok (for sure these tests are covered over in the Scan of memstore tests?). Ship it if all tests pass. - stack On 2010-06-29 09:30:27, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/240/ > ----------------------------------------------------------- > > (Updated 2010-06-29 09:30:27) > > > Review request for hbase. > > > Summary > ------- > > Remove remaining Get code from Store.java,etc > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 40205c4 > src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java 7eac029 > > src/main/java/org/apache/hadoop/hbase/regionserver/ReadWriteConsistencyControl.java > 574e88a > src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 9c720b1 > src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java d865e38 > src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java > 9c1c95c > src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 48b8ac0 > src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java > 4f27ea5 > src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java b15ae53 > > Diff: http://review.hbase.org/r/240/diff > > > Testing > ------- > > > Thanks, > > Ryan > >