----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/278/#review318 -----------------------------------------------------------
Ship it! Few nits, commit if it passes all tests. src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java <http://review.hbase.org/r/278/#comment1385> Is there a jira for that? src/main/java/org/apache/hadoop/hbase/regionserver/ReadWriteConsistencyControl.java <http://review.hbase.org/r/278/#comment1386> some javadoc ploz src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java <http://review.hbase.org/r/278/#comment1387> document src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java <http://review.hbase.org/r/278/#comment1388> not needed - Jean-Daniel On 2010-07-07 14:58:38, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/278/ > ----------------------------------------------------------- > > (Updated 2010-07-07 14:58:38) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2803 continues to remove more get code from the codebase. > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 40205c4 > src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java 7eac029 > > src/main/java/org/apache/hadoop/hbase/regionserver/ReadWriteConsistencyControl.java > 574e88a > src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 9c720b1 > src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 6a58881 > src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java > 9c1c95c > src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 48b8ac0 > src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java > 4f27ea5 > src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java b15ae53 > > Diff: http://review.hbase.org/r/278/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
