> On 2010-07-16 13:23:13, stack wrote: > > src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java, line 404 > > <http://review.hbase.org/r/325/diff/1/?file=2838#file2838line404> > > > > See KeyValue.matchingQualifier() or KeyValue.matchingColumn
they dont take offset,length so i wasnt able to use them > On 2010-07-16 13:23:13, stack wrote: > > src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java, line 386 > > <http://review.hbase.org/r/325/diff/1/?file=2838#file2838line386> > > > > Why not just use newKv? If there is a kv in front of newKv, then our > > counters are going to be off? good point > On 2010-07-16 13:23:13, stack wrote: > > src/main/java/org/apache/hadoop/hbase/regionserver/Store.java, line 1301 > > <http://review.hbase.org/r/325/diff/1/?file=2839#file2839line1301> > > > > There is a tab here? fixed - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/325/#review412 ----------------------------------------------------------- On 2010-07-15 17:09:30, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/325/ > ----------------------------------------------------------- > > (Updated 2010-07-15 17:09:30) > > > Review request for hbase. > > > Summary > ------- > > rework ICV by no longer requiring getWithCode() and also by keeping the > timestamp 'fresh' instead of updating 'in place'. > > > This addresses bug HBASE-2553. > http://issues.apache.org/jira/browse/HBASE-2553 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java ae94578 > src/main/java/org/apache/hadoop/hbase/regionserver/Store.java d2f65f4 > src/main/java/org/apache/hadoop/hbase/util/Bytes.java 1b46f2d > src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java f732466 > > Diff: http://review.hbase.org/r/325/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
