> On 2010-07-20 20:35:37, stack wrote: > > +1 > > stack wrote: > Oh, there is no associated issue. Open one please Alex so I can close it > with the commit. Attach this good patch to it (sorry for the overhead)
no worries i love filing jiras! - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/339/#review436 ----------------------------------------------------------- On 2010-07-20 10:49:11, Alex Newman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/339/ > ----------------------------------------------------------- > > (Updated 2010-07-20 10:49:11) > > > Review request for hbase and stack. > > > Summary > ------- > > TestHLOG does a bunch of old style tests I like the new style ones better. I > bet you do as well. any suggestions on what I should do with the getname > function? > > > Diffs > ----- > > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java > 211162e > > Diff: http://review.hbase.org/r/339/diff > > > Testing > ------- > > I reran its tests. > > > Thanks, > > Alex > >
