-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/354/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

There are tricky edge cases that were removed by HBASE-2553 (oopsy!)... flaky 
tests have been illustrating them. This patch fixes those flaky tests to be not 
flaky (using the EnvironmentEdgeManager thing) and also fixes them, and 
introduces tests that cover the particular use cases slightly better as well. 
Oh yes and and fixes the actual bug.

Without these fixes we would end up with KVs with different values with the 
same Timestamp which causes problems.  This can happen when we get more than 1 
increment/millisecond and especially during a snapshot.


This addresses bug HBASE-2863.
    http://issues.apache.org/jira/browse/HBASE-2863


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/KeyValue.java e32d683 
  src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java 44fa0c3 
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java c1ff9f2 
  src/main/java/org/apache/hadoop/hbase/util/ManualEnvironmentEdge.java 
PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 4ead02d 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java a32eed6 

Diff: http://review.hbase.org/r/354/diff


Testing
-------


Thanks,

Ryan

Reply via email to