----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/380/#review471 -----------------------------------------------------------
Some nits, I'm also trying it out (with the update=true fix) trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java <http://review.hbase.org/r/380/#comment1962> Remove all the trailing white spaces trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java <http://review.hbase.org/r/380/#comment1963> Reuse curState and newState instead trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java <http://review.hbase.org/r/380/#comment1961> Simply return when you figure that you should, then you can get rid of "update" - Jean-Daniel On 2010-07-23 14:53:37, Karthik Ranganathan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/380/ > ----------------------------------------------------------- > > (Updated 2010-07-23 14:53:37) > > > Review request for hbase, stack and Kannan Muthukkaruppan. > > > Summary > ------- > > Region permanently offlined - if the ZNode is already in the target state, do > not update it again. > > > This addresses bug HBASE-2866. > http://issues.apache.org/jira/browse/HBASE-2866 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java > 967128 > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java > 967128 > > Diff: http://review.hbase.org/r/380/diff > > > Testing > ------- > > Ran unit tests, went through fine (except TestRowAtomicity, which is known to > be failing). > > > Thanks, > > Karthik > >
