-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/382/
-----------------------------------------------------------
(Updated 2010-07-23 16:26:26.834022)
Review request for hbase, stack, Jean-Daniel Cryans, Karthik Ranganathan, and
Kannan Muthukkaruppan.
Changes
-------
Whitespace cleanup
Summary
-------
This method implements all the zookeeper methods needed for this last part of
the doc posted in HBASE-2692 (definition of valid creation/transitions for
unassigned znodes):
MASTER
1. Master creates an unassigned node as OFFLINE.
- Cluster startup and table enabling.
2. Master forces an existing unassigned node to OFFLINE.
- RegionServer failure.
- Allows transitions from all states to OFFLINE.
3. Master deletes an unassigned node that was in a OPENED state.
- Normal region transitions. Besides cluster startup, no other deletions
of unassigned nodes is allowed.
4. Master deletes all unassigned nodes regardless of state.
- Cluster startup before any assignment happens.
REGIONSERVER
1. RegionServer creates an unassigned node as CLOSING.
- All region closes will do this in response to a CLOSE RPC from Master.
- A node can never be transitioned to CLOSING, only created.
2. RegionServer transitions an unassigned node from CLOSING to CLOSED.
- Normal region closes. CAS operation.
3. RegionServer transitions an unassigned node from OFFLINE to OPENING.
- All region opens will do this in response to an OPEN RPC from the Master.
- Normal region opens. CAS operation.
4. RegionServer transitions an unassigned node from OPENING to OPENED.
- Normal region opens. CAS operation.
This addresses bug HBASE-2697.
http://issues.apache.org/jira/browse/HBASE-2697
Diffs (updated)
-----
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
PRE-CREATION
Diff: http://review.hbase.org/r/382/diff
Testing
-------
Unit test to come. Just putting up since there have been some recent issues
with multiple transitions and stuff, wanted to show what the new stuff looks
like.
Thanks,
Jonathan
