----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/372/#review496 -----------------------------------------------------------
Ship it! +1 Will commit in a little while. - stack On 2010-07-24 05:10:08, Chongxin Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/372/ > ----------------------------------------------------------- > > (Updated 2010-07-24 05:10:08) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2792: Create a better way to chain log cleaners > > > This addresses bug HBASE-2792. > http://issues.apache.org/jira/browse/HBASE-2792 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java > 3ca3611 > src/main/java/org/apache/hadoop/hbase/master/LogsCleaner.java 37b2c3c > src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 9fb1cce > > src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java > eb859aa > src/main/resources/hbase-default.xml e3a9669 > src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java a92e0da > > Diff: http://review.hbase.org/r/372/diff > > > Testing > ------- > > Unit test TestOldLogsCleaner passed. > > > Thanks, > > Chongxin > >