----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/387/ -----------------------------------------------------------
(Updated 2010-07-27 09:31:00.269382) Review request for hbase, stack and Karthik Ranganathan. Changes ------- Just attaching to HBASE-2695 to see if it makes it to the lists now Summary ------- This is the rest of the master cleanup and zookeeper cleanup. Everything is moved over to the new ZooKeeperWatcher, ZooKeeperListeners, ZKUtil/ZKAssign, etc... There is a second page to the diff linked at the bottom with lots of good stuff, don't miss it! Now on to the good stuff! This addresses bug HBASE-2695. http://issues.apache.org/jira/browse/HBASE-2695 Diffs ----- branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/Abortable.java PRE-CREATION branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/MiniZooKeeperCluster.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/ServerController.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/executor/HBaseEventHandler.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/executor/HBaseExecutorService.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/executor/RegionTransitionData.java PRE-CREATION branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/executor/RegionTransitionEventData.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java PRE-CREATION branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/ProcessRegionOpen.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/ZKUnassignedWatcher.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/handler/MasterCloseRegionHandler.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/master/handler/MasterOpenRegionHandler.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/regionserver/MasterAddressManager.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/regionserver/RSZookeeperUpdater.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java PRE-CREATION branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/RegionServerTracker.java PRE-CREATION branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java PRE-CREATION branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java PRE-CREATION branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 964617 branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperNodeTracker.java PRE-CREATION branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 964617 branches/0.90_master_rewrite/src/main/resources/hbase-webapps/master/master.jsp 964617 branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 964617 branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/TestMultiParallelPut.java 964617 branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/OOMEHMaster.java 964617 branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 964617 branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestMasterTransitions.java 964617 branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/master/TestRestartCluster.java 964617 branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java 964617 branches/0.90_master_rewrite/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperNodeTracker.java PRE-CREATION Diff: http://review.hbase.org/r/387/diff Testing ------- Most unit tests passing. Still addressing remaining failures but most seem to be related to the fact that I was running multiple tests and ZK clusters were stomping on each other. Thanks, Jonathan