> On 2010-08-04 21:43:56, stack wrote: > > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServer.java, > > line 49 > > <http://review.cloudera.org/r/334/diff/2/?file=2893#file2893line49> > > > > Should we even include this test Pranav? I don't see where you are > > proving that we do not exceed the limit or that the limit works. Also, > > where are you making the splits in this test? > > > > I'm fine committing the patch without this test -- the code as is looks > > fine to me. > > Pranav Khaitan wrote: > Stack, > > In the test, splits are being made by inserting lot of data and checking > frequently for splits. However, it is a time consuming test. I completely > agree with you that the tests for this are not really necessarily and they > require a lot of testing time. I was under the impression that any change > requires a corresponding test and therefore added it.
Tests are required unless the test does more harm than good (smile). Let me commit w/o this particular test. Thanks Pranav. - stack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/334/#review678 ----------------------------------------------------------- On 2010-07-16 17:58:51, Pranav Khaitan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/334/ > ----------------------------------------------------------- > > (Updated 2010-07-16 17:58:51) > > > Review request for hbase, Jonathan Gray, Karthik Ranganathan, and Kannan > Muthukkaruppan. > > > Summary > ------- > > This patch is for capping the number of regions on a region server depending > on different use-cases. We add a parameter in the config file which can be > used by the user to set this value. The default value is INT_MAX. > > > This addresses bug HBASE-2844. > http://issues.apache.org/jira/browse/HBASE-2844 > > > Diffs > ----- > > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java > 964968 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 964968 > trunk/src/main/resources/hbase-default.xml 964968 > > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServer.java > PRE-CREATION > > Diff: http://review.cloudera.org/r/334/diff > > > Testing > ------- > > Existing tests passing. Written more specialized tests at HRegionServer level > > > Thanks, > > Pranav > >
