----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/396/#review752 -----------------------------------------------------------
Ship it! Looks good to me. - stack On 2010-08-05 14:55:17, Nicolas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/396/ > ----------------------------------------------------------- > > (Updated 2010-08-05 14:55:17) > > > Review request for hbase. > > > Summary > ------- > > There is a very corner case when bad things could happen(ie data loss): > > 1) RS #1 is going to roll its HLog - not yet created the new one, old one > will get no more writes > 2) RS #1 enters GC Pause of Death > 3) Master lists HLog files of RS#1 that is has to split as RS#1 is dead, > starts splitting > 4) RS #1 wakes up, created the new HLog (previous one was rolled) and appends > an edit - which is lost > > Note that this fix requires a healthy dose of HDFS prerequisites: HDFS-617, > HADOOP-6840, HADOOP-6886. I encourage you to review those as well, give > feedback, and hopefully give +1s so we can push the changes through. > > > This addresses bug HBASE-2312. > http://issues.apache.org/jira/browse/HBASE-2312 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 982788 > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 982788 > > trunk/src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java > 982788 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java > 982788 > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java > 982788 > > trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java > 982788 > > Diff: http://review.cloudera.org/r/396/diff > > > Testing > ------- > > mvn test; > bin/start-hbase.sh > bin/hbase shell < scan '.META.', get, put, etc > > > Thanks, > > Nicolas > >
