----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/632/#review894 -----------------------------------------------------------
Ship it! I'll fix the minor crud below. I tried it in standalone and it doesn't break anything and the restart in this case works as advertised. Will try later on cluster. Nice patch Nicolas. trunk/bin/rolling-restart.sh <http://review.cloudera.org/r/632/#comment2916> Its 2010 trunk/bin/rolling-restart.sh <http://review.cloudera.org/r/632/#comment2917> There is white space here and on a few other lines - stack On 2010-08-12 12:36:09, Nicolas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/632/ > ----------------------------------------------------------- > > (Updated 2010-08-12 12:36:09) > > > Review request for hbase. > > > Summary > ------- > > 1. added 'restart' option to hbase-daemon.sh for unit-level restarting > 2. added rolling-restart.sh script to perform system-level rolling restarts > > (Note that I intentionally did not restart the ZooKeeper nodes, since those > binaries will need an update far less often) > > > This addresses bug HBASE-1660. > http://issues.apache.org/jira/browse/HBASE-1660 > > > Diffs > ----- > > trunk/bin/hbase-daemon.sh 984635 > trunk/bin/regionservers.sh 984635 > trunk/bin/rolling-restart.sh PRE-CREATION > > Diff: http://review.cloudera.org/r/632/diff > > > Testing > ------- > > ./bin/start-hbase.sh > ./bin/rolling-restart.sh > ./bin/stop-hbase.sh > > > Thanks, > > Nicolas > >
