----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/151/#review1057 -----------------------------------------------------------
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Get.java <http://review.cloudera.org/r/151/#comment3362> oversight. fixed now. http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java <http://review.cloudera.org/r/151/#comment3364> fixed http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java <http://review.cloudera.org/r/151/#comment3363> fixed http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java <http://review.cloudera.org/r/151/#comment3367> i made the return type void instead. http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java <http://review.cloudera.org/r/151/#comment3365> fixed http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3352> Fixing spaces. Compile error without (List) cast: method processBatch(List<Row> ...) is not applicable for argument type ArrayList<Put>. http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3353> fixed http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3354> fixed http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3368> I think the parens aid readability. http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3355> I have abort and maintain the thread interupted status now. http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3369> fixed http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3356> I added a 1000 ms timeout for the future.get. Hope that is a reasonable time limit. I still allow for a retry in this case. Not confident this is the right behavior. http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3357> fixed. Sticking with Entry. http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3358> fixed http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3359> fixed, as above. http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3360> Cast is necessary. Otherwise method would have to declare itself as Throws Throwable (the return type of e.getCause()). http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3361> fixed http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/151/#comment3370> spaces fixed http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java <http://review.cloudera.org/r/151/#comment3371> marked final, but needs to be public for use in HRegionInterface. http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java <http://review.cloudera.org/r/151/#comment3372> thanks http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiPut.java <http://review.cloudera.org/r/151/#comment3373> fixed - message can go after @deprecated in javadoc http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/151/#comment3374> fixed http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/151/#comment3375> Could refactor to add a "doAction()" method to each Action delegate? - Marc On 2010-06-06 23:23:22, Marc Limotte wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/151/ > ----------------------------------------------------------- > > (Updated 2010-06-06 23:23:22) > > > Review request for hbase. > > > Summary > ------- > > Updated the patch to work on the trunk. New unit tests are in > TestMultiParallel.java, which replaces TestMultiParallelPut.java. > > > This addresses bug HBASE-1845. > http://issues.apache.org/jira/browse/HBASE-1845 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Action.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Get.java > 951973 > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java > 951973 > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 951973 > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java > 951973 > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiPut.java > 951973 > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiPutResponse.java > 951973 > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Row.java > 951973 > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java > 951973 > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java > 951973 > > http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 951973 > > http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestMultiParallel.java > PRE-CREATION > > http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestMultiParallelPut.java > 951973 > > Diff: http://review.cloudera.org/r/151/diff > > > Testing > ------- > > > Thanks, > > Marc > >
