----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/846/#review1216 -----------------------------------------------------------
Ship it! src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java <http://review.cloudera.org/r/846/#comment4128> do you not have to wait here until indication that the selector thread has woken up and is in the "wait" loop? I'm not 100% sure of the state preconditions for the NIO stuff - Todd On 2010-09-14 15:43:46, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/846/ > ----------------------------------------------------------- > > (Updated 2010-09-14 15:43:46) > > > Review request for hbase. > > > Summary > ------- > > HBASE-2941 reader threads for hbase rpc > > > This addresses bug HBASE-2941. > http://issues.apache.org/jira/browse/HBASE-2941 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java d3c6c21 > > Diff: http://review.cloudera.org/r/846/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
