> On 2010-09-17 16:25:15, Todd Lipcon wrote: > > src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java, line > > 142 > > <http://review.cloudera.org/r/873/diff/1/?file=11929#file11929line142> > > > > hrm, I guess that's a good idea, but something seems a little strange > > about this :)
Yeah, this is a little 'bold' but trying to think around it, i couldn't see issue w/ it, whereas not doing it is going to frustrate as restart will have this minute or so stall while we waiting on the znode expire. I'd say its good for now and I suppose we'll see later if it becomes a prop. > On 2010-09-17 16:25:15, Todd Lipcon wrote: > > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 222 > > <http://review.cloudera.org/r/873/diff/1/?file=11931#file11931line222> > > > > this should probably move down until after we're the active master sure... will do on commit. - stack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/873/#review1267 ----------------------------------------------------------- On 2010-09-17 01:37:45, stack wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/873/ > ----------------------------------------------------------- > > (Updated 2010-09-17 01:37:45) > > > Review request for hbase. > > > Summary > ------- > > Patch changes catalogtracker to not connect to root on start. Instead, wait > on kick from zk before going after root or meta. This change doesn't address > the case where a RS can get stuck on itself trying to connect to an RPC that > is not yet running. Rather it sidesteps (We should come back and do > something about non-timeout when setting up proxy since its possible. I'll > file an issue on it). Patch includes other fixups, not all cosmetic. > > M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java > Add a test for case where master comes up and up in zk the > master znode contains our address > D src/test/java/org/apache/hadoop/hbase/master/TestMinimumServerCount.java > Removed test of something we no longer do; wait on an explicit number > of regions to come in before we'll go ahead w/ master startup. > M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > Swapped order in which we do some of the startup (Cosmetic) > M src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java > Javadoc > M src/main/java/org/apache/hadoop/hbase/master/ServerManager.java > Removed minimumServerCount. Seems bad predicating master startup > on N RS's coming in. > Renamed method numServers as countOfRegionServers and made it protected. > Removed other unused methods. > Redid waitForMinServers as waitForRegionServers... where we just > hang around until count of regionservers stabilizes. TODO: improve > M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java > Handle case where the current master znode has our address; in this > case we can hurry up the expiration by deleting the znode. > M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Minor formatting > M src/main/java/org/apache/hadoop/hbase/master/HMaster.java > Renamed clusterStarter as freshClusterStartup. Predicate this boolean > off the count of regionservers. If 0, then fresh cluster start. Else > do special handling (TODO). > Edit on HMaster constructor comments. > Moved some code out of Master constructor into stackIfBackupMaster method > If aborting set stop flag. > M src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java > Removed unused imports. > M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java > Make catalogtracker lazy about getting metalocation....don't do it > on start. > > > This addresses bug hbase-3010. > http://issues.apache.org/jira/browse/hbase-3010 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 2bcd5d0 > src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java > 87fe9cd > src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 690f78c > src/main/java/org/apache/hadoop/hbase/master/HMaster.java c1b80eb > src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java > c675db9 > src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 498650f > src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 528bb9d > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1ec7f4e > src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java > 030bc12 > src/test/java/org/apache/hadoop/hbase/master/TestMinimumServerCount.java > d6f2c02 > > Diff: http://review.cloudera.org/r/873/diff > > > Testing > ------- > > Can now start/stop cluster repeatedly. > > > Thanks, > > stack > >
