----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/927/#review1369 -----------------------------------------------------------
Ship it! - Andrew On 2010-09-30 13:50:57, Jonathan Gray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/927/ > ----------------------------------------------------------- > > (Updated 2010-09-30 13:50:57) > > > Review request for hbase, stack and Andrew Purtell. > > > Summary > ------- > > This method adds Configuration as a parameter to almost all the rest classes. > This is because they all extend a base class, ResourceBase, which just holds > a reference to a single RESTServlet that gets instantiated as a singleton. > It's this RESTServlet which needs to take a Configuration. Since > ResourceBase is instantiated all over the place, everything needs > Configuration. > > This doesn't work though. Most of these classes get instantiated through > REST/JAX automagic, so it's getting null Configuration. > > Could use some help. > > > This addresses bug HBASE-3058. > http://issues.apache.org/jira/browse/HBASE-3058 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java 1003250 > > trunk/src/test/java/org/apache/hadoop/hbase/rest/HBaseRESTClusterTestBase.java > 1003206 > > Diff: http://review.cloudera.org/r/927/diff > > > Testing > ------- > > REST tests failing now with NPE because everything gets null Configuration > objects. Without patch they fail because they try to contact the wrong > master. > > > Thanks, > > Jonathan > >
