----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/926/#review1368 -----------------------------------------------------------
Just a few comments/questions, but looks good to me. trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/926/#comment4531> Have you seen this? I guess this is kind of stuff that would happen on failed-over master? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/926/#comment4533> So basic assumption here for startup is that master and no RS will fail. I'm fine with that. This bulk assign only done on startup, right? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/926/#comment4534> No race here? What if region server transitions to OPENING already before we get here? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/926/#comment4535> yay i <3 plans trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/926/#comment4536> I am generally +1 on aborting if we get to some thing we expect to never happen. Then we're sure to notice it. And master aborting is generally not a cluster breaker anyways. trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/926/#comment4537> +1 trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/926/#comment4538> not sure i follow what it means if we time out, but should only happen if something dies? or takes a really long time? trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/926/#comment4539> sweet & easy - Jonathan On 2010-09-30 12:55:33, stack wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/926/ > ----------------------------------------------------------- > > (Updated 2010-09-30 12:55:33) > > > Review request for hbase. > > > Summary > ------- > > hbase-3019 Make bulk assignment on cluster startup run faster > > M src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java > Disable test rather than comment out @Test. junit complains no > test if do latter. > M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > M src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java > openRegions: Added > M src/main/java/org/apache/hadoop/hbase/master/ServerManager.java > sendOpenRegions: Added > M src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > Add bulk assign method Add ExecutorService to run bulk assignements. > M > src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java > Enhance logging. > > > This addresses bug hbase-3019. > http://issues.apache.org/jira/browse/hbase-3019 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java > 1003192 > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > 1003192 > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java > 1003192 > > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java > 1003192 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1003192 > trunk/src/test/java/org/apache/hadoop/hbase/master/TestLogsCleaner.java > 1003192 > > Diff: http://review.cloudera.org/r/926/diff > > > Testing > ------- > > I've been running patch up on testing cluster... starting and stopping then > confirming all regions on line by running rowcounter. > > > Thanks, > > stack > >
