----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1039/#review1560 -----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/HConstants.java <http://review.cloudera.org/r/1039/#comment5259> do we want to migrate class-specific static config to those classes? src/main/java/org/apache/hadoop/hbase/rest/Main.java <http://review.cloudera.org/r/1039/#comment5260> where did DEFAULT_LISTEN_PORT go to? i am not seeing it removed? src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java <http://review.cloudera.org/r/1039/#comment5262> this looks clever, is it more generically useful to other parts of hbase? src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java <http://review.cloudera.org/r/1039/#comment5261> redundant assignment? src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java <http://review.cloudera.org/r/1039/#comment5263> ditto on this one. i wonder if there might be an elegant way to retry or redo zk operations, but there might not be. src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java <http://review.cloudera.org/r/1039/#comment5264> is this better called startZooKeeperClient? src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java <http://review.cloudera.org/r/1039/#comment5265> does this mean that stats are only updated every minute by default? - Ryan On 2010-10-18 14:46:30, Andrew Purtell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1039/ > ----------------------------------------------------------- > > (Updated 2010-10-18 14:46:30) > > > Review request for hbase. > > > Summary > ------- > > This change allows the REST interface to publish its endpoint and metrics, > currently only requests/sec, into ZooKeeper. By default a permanent znode > tree is created as needed at /hbase/rest/status and Stargate instances create > ephemeral children of this with names in the format <host>:<port>. The > ephemeral znodes contain JSON serialized information about the instance, e.g. > > > {"connector":{"host":"restserver.example.com","port":"8080"},"statistics":{"requests":"13"}} > > The function of Stargate itself is not affected, except for one significant > change: now if the ZooKeeper service is lost, the Stargate instances will > abort along with the rest of HBase. > > > This addresses bug HBASE-3119. > http://issues.apache.org/jira/browse/HBASE-3119 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/HConstants.java 71c3e7b > src/main/java/org/apache/hadoop/hbase/rest/Main.java 368b4b4 > src/main/java/org/apache/hadoop/hbase/rest/RESTServlet.java ed92857 > src/main/java/org/apache/hadoop/hbase/rest/metrics/RESTMetrics.java 284bbc5 > > Diff: http://review.cloudera.org/r/1039/diff > > > Testing > ------- > > > Thanks, > > Andrew > >
