----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1042/#review1569 -----------------------------------------------------------
Ship it! Just small stuff. Whitespace. Maybe some additional comments in HTablePool about changed behavior. And removal of one debug line I like. +1, can fix small stuff on commit trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java <http://review.cloudera.org/r/1042/#comment5280> Awesome comment. trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/1042/#comment5282> trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/1042/#comment5281> whitespace trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.cloudera.org/r/1042/#comment5283> lots of whitespace in htable, should just clean it all i guess trunk/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java <http://review.cloudera.org/r/1042/#comment5284> Worth adding any comments to HTablePool about this behavior? It will use it's own set of connections / zk / region cache and you should closeTablePool() it at the end. trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1042/#comment5285> Reason for dropping this? I was actually using this line as helpful debug yesterday. trunk/src/main/java/org/apache/hadoop/hbase/master/LogCleaner.java <http://review.cloudera.org/r/1042/#comment5286> whitespace - Jonathan On 2010-10-18 16:05:14, stack wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1042/ > ----------------------------------------------------------- > > (Updated 2010-10-18 16:05:14) > > > Review request for hbase and Jonathan Gray. > > > Summary > ------- > > See the issue. Has a commit message describing patch: > https://issues.apache.org/jira/browse/HBASE-2669 > > > This addresses bug HBASE-2669. > http://issues.apache.org/jira/browse/HBASE-2669 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java 1023967 > > trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java > 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java > 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/master/LogCleaner.java 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java > 1023967 > > trunk/src/main/java/org/apache/hadoop/hbase/master/TimeToLiveLogCleaner.java > 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1023967 > > trunk/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java > 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/util/HMerge.java 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 1023967 > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java > 1023967 > > Diff: http://review.cloudera.org/r/1042/diff > > > Testing > ------- > > unit tests pass > > > Thanks, > > stack > >
