> On 2010-10-20 17:54:04, Jonathan Gray wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java, > > line 103 > > <http://review.cloudera.org/r/1057/diff/1/?file=15040#file15040line103> > > > >
Not sure where my comment went :) Just wondering if in the rolling restart case, we aren't aborting, right? Is the stop() now a hard stop and that's why we need to close regions first? - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1057/#review1594 ----------------------------------------------------------- On 2010-10-20 16:51:25, stack wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1057/ > ----------------------------------------------------------- > > (Updated 2010-10-20 16:51:25) > > > Review request for hbase, Jean-Daniel Cryans and Jonathan Gray. > > > Summary > ------- > > Fix 'hbase zkcli' so it reads zk ensemble location from hbase config/zoo.cfg. > This fixes rolling restart. Patch also includes fix so rolling restarts > work on new master. > > A > src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java > Test for new TZMSA class. > M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java > Minor edit of javadoc. > A src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java > Tool to emit what ZooKeeperMain wants for a server argument. > M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > (isAbort): Added. > M src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java > Shutdown hook now needs to startup region shutdowns since new > master changed how shutdown sequence runs. > M > src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java > Don't do opens if server is stopped. > M > src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java > Minor formatting. > M bin/hbase > Run new ZKMSA tool to figure '-server host:port' to pass ZKM > M bin/hbase-daemon.sh > Make default wait be longer. > > > This addresses bug hbase-2998. > http://issues.apache.org/jira/browse/hbase-2998 > > > Diffs > ----- > > trunk/bin/hbase 1025785 > trunk/bin/hbase-daemon.sh 1025785 > > trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java > 1025785 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1025785 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java > 1025785 > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java > 1025785 > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java > 1025785 > > trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java > PRE-CREATION > > trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java > PRE-CREATION > > Diff: http://review.cloudera.org/r/1057/diff > > > Testing > ------- > > > Thanks, > > stack > >
