----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1063/#review1602 -----------------------------------------------------------
Ship it! Looks good. - Andrew On 2010-10-21 11:35:11, stack wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1063/ > ----------------------------------------------------------- > > (Updated 2010-10-21 11:35:11) > > > Review request for hbase and Andrew Purtell. > > > Summary > ------- > > Andrew, can you look at this? Its making the TableRegionModel do the new > HRegionInfo name format. Has a few tests even. I also changed the > TestTableResource back to old style compare of region names and now it passes. > > > This addresses bug hbase-2658. > http://issues.apache.org/jira/browse/hbase-2658 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java 1026078 > trunk/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java 1026078 > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java > 1026078 > > trunk/src/main/java/org/apache/hadoop/hbase/rest/model/TableRegionModel.java > 1026078 > trunk/src/main/java/org/apache/hadoop/hbase/util/MetaUtils.java 1026078 > trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java > 1026078 > > trunk/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java > 1026078 > > Diff: http://review.cloudera.org/r/1063/diff > > > Testing > ------- > > > Thanks, > > stack > >
