review board gave me timeout. The reason for this change is that ThreadPoolExecutor would try to enqueue before maxPoolSize is reached. Please refer to ThreadPoolExecutor.execute() method.
On Fri, Oct 22, 2010 at 6:02 AM, <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1064/#review1605 > ----------------------------------------------------------- > > Ship it! > > > +1 Missing explaination of why you have to make this crazy hbase queue in > first place. > > > trunk/src/main/java/org/apache/hadoop/hbase/executor/m2m-integration builds > Service.java > <http://review.cloudera.org/r/1064/#comment5413> > > Doc why this oddness. > > > > trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java > <http://review.cloudera.org/r/1064/#comment5412> > > Say why we even need this crazy queue; i.e. because excecutorservice is > weird. > > > - stack > > > On 2010-10-21 14:59:17, Jonathan Gray wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://review.cloudera.org/r/1064/ > > ----------------------------------------------------------- > > > > (Updated 2010-10-21 14:59:17) > > > > > > Review request for hbase and stack. > > > > > > Summary > > ------- > > > > See HBASE-3139 > > > > > > Diffs > > ----- > > > > > trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java > 1026145 > > > trunk/src/test/java/org/apache/hadoop/hbase/executor/TestExecutorService.java > PRE-CREATION > > > > Diff: http://review.cloudera.org/r/1064/diff > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Jonathan > > > > > >
