----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1046/#review1628 -----------------------------------------------------------
Chatting offline w/ R and J-D, this patch is good if hfiles but no good if no files yet (Ryan pointed this out). So, we need combo of this and J-Ds schema check. RS won't go down. RS just won't deploy a region that requires an uninstalled codec. I think thats the way to go. trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java <http://review.cloudera.org/r/1046/#comment5483> Remove TODO trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <http://review.cloudera.org/r/1046/#comment5484> Where is 'feature' documented? - stack On 2010-10-22 15:43:55, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1046/ > ----------------------------------------------------------- > > (Updated 2010-10-22 15:43:55) > > > Review request for hbase. > > > Summary > ------- > > RegionServer should refuse to be assigned a region that use LZO when LZO > isn't available > > - instead of checking regions during open, i do a check and throw during the > construction of the RS that is is able to instantiate the listed codecs. > > > This addresses bug HBASE-2514. > http://issues.apache.org/jira/browse/HBASE-2514 > > > Diffs > ----- > > trunk/CHANGES.txt 1024074 > trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java > 1024073 > trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 1024073 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1024074 > trunk/src/main/java/org/apache/hadoop/hbase/util/CompressionTest.java > 1024073 > trunk/src/test/java/org/apache/hadoop/hbase/util/TestCompressionTest.java > PRE-CREATION > > Diff: http://review.cloudera.org/r/1046/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
