----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1077/#review1633 -----------------------------------------------------------
Looks great J-D but no +1 until you've added a unit test that proves your parse stuff in ZKUtil does the right thing when single ensemble member, many ensemble members, empty port spec., etc. (No need to post the patch with unit test -- just commit) /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java <http://review.cloudera.org/r/1077/#comment5492> Minor spacing issue here? - stack On 2010-10-22 18:04:22, Jean-Daniel Cryans wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1077/ > ----------------------------------------------------------- > > (Updated 2010-10-22 18:04:22) > > > Review request for hbase. > > > Summary > ------- > > Does exactly what this jira is about, and refactors all the cluster key > processing into ZKUtil. > > > This addresses bug HBASE-3012. > http://issues.apache.org/jira/browse/HBASE-3012 > > > Diffs > ----- > > /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/CopyTable.java > 1026525 > > /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java > 1026525 > > /trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java > 1026525 > > /trunk/src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeper.java > 1026525 > /trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 1026525 > > Diff: http://review.cloudera.org/r/1077/diff > > > Testing > ------- > > > Thanks, > > Jean-Daniel > >
