----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1055/#review1676 -----------------------------------------------------------
Ship it! Based on discussion in JIRA, I'm fine addressing naming issue mentioned later. FWIW, has my approval. Ship it! - Gary On 2010-10-21 18:59:12, Nicolas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1055/ > ----------------------------------------------------------- > > (Updated 2010-10-21 18:59:12) > > > Review request for hbase. > > > Summary > ------- > > Example: a useful metric to observe track is compaction count + duration. > Since compactions are long running and only happen infrequently, the > avg/opcount stats are should be reset longer than the default polling period > (5 sec). In addition to 'hbase.period', we should allow a different duration > after which long-running metrics should expire. This would also fix our > existing metrics problem where min/max stats are never reset until the > process is restarted/upgraded. > > This diff adds the capability for long-running metrics in addition to the > infrastructure necessary to log compactions + log splits. > > > This addresses bug HBASE-3102. > http://issues.apache.org/jira/browse/HBASE-3102 > > > Diffs > ----- > > trunk/conf/hadoop-metrics.properties 1025790 > trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1025790 > trunk/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java > 1025790 > trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java > 1025790 > > trunk/src/main/java/org/apache/hadoop/hbase/master/metrics/MasterMetrics.java > 1025790 > > trunk/src/main/java/org/apache/hadoop/hbase/metrics/PersistentMetricsTimeVaryingRate.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java > 1025790 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > 1025790 > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java > 1025790 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1025790 > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java > 1025790 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java > 1025790 > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java > 1025790 > trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java > 1025790 > > Diff: http://review.cloudera.org/r/1055/diff > > > Testing > ------- > > mvn clean install > cluster load test > ** Note: this was primarily tested on 0.89. Minimal testing on 0.90 > > > Thanks, > > Nicolas > >
