-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1115/
-----------------------------------------------------------
(Updated 2010-10-29 13:24:54.726844)
Review request for hbase and Nicolas.
Summary
-------
So I took the approach taken with the instrumented sequence file rider. Not
sure if exposing those methods in the WALReader is cool so I am down with other
suggestions.
- Add a FaultySequenceFileLogReader
- Un-commented the 2935 tests
This addresses bug hbase-2935.
http://issues.apache.org/jira/browse/hbase-2935
Diffs
-----
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java c8a10af
src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogReader.java
0b7dc78
src/test/java/org/apache/hadoop/hbase/regionserver/wal/FaultySequenceFileLogReader.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
473c359
Diff: http://review.cloudera.org/r/1115/diff
Testing
-------
Running on our internal hudson as I type this. Also I ran the TestHLogSplit
test locally. I'll update the review if hudson is green.
Thanks,
Alex
