----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1132/#review1716 -----------------------------------------------------------
Ship it! Looks good to me. trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java <http://review.cloudera.org/r/1132/#comment5646> This a migration problem? - stack On 2010-10-29 19:42:21, Jonathan Gray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1132/ > ----------------------------------------------------------- > > (Updated 2010-10-29 19:42:21) > > > Review request for hbase, stack, Ryan Rawson, and khemani. > > > Summary > ------- > > TimeRange now part of Increment. Adds new methods into Increment w/ javadoc. > Adds code in our increment operation to set this onto the Gets we use. > > > This addresses bug HBASE-3162. > http://issues.apache.org/jira/browse/HBASE-3162 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/client/Increment.java 1028936 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > 1028936 > > Diff: http://review.cloudera.org/r/1132/diff > > > Testing > ------- > > increment tests passing. > > > Thanks, > > Jonathan > >
