-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1143/
-----------------------------------------------------------
(Updated 2010-10-31 17:05:24.252151)
Review request for hbase and stack.
Changes
-------
Bit of cleanup on tests to make them compatible with the new changes. For
example, master cannot have PENDING_OPEN w/o existence of a zk node... and we
never have to handle a node in CLOSING during failover (on RS, we will always
do one of three: transition to closed, delete from closing, die).
TestMasterFailover and TestRollingRestart (@ 50 regions) are both passing.
Summary
-------
Does cleanup of RIT timeouts according to document in progress. Still
finishing document but I'd like to get this patch tested before finalizing it.
Also found some strange stuff in server shutdown handling that could have
easily led to some double assignment issues that stack was seeing.
This addresses bug HBASE-3181.
http://issues.apache.org/jira/browse/HBASE-3181
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
1029507
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1029507
trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
1029507
trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
1029507
trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
1029507
trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
1029507
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1029507
trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
1029507
trunk/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java
1029507
Diff: http://review.cloudera.org/r/1143/diff
Testing
-------
Working on tests now. This definitely changes some behavior that is tested in
the new TestMasterFailover so need to figure if the test should change or
whether we need to handle things like CLOSING. Maybe let it timeout a few
times?
Thanks,
Jonathan
