----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1142/#review1752 -----------------------------------------------------------
Ship it! +1 on commit because of Hairong remarks up in issue. - stack On 2010-10-31 12:45:13, Jonathan Gray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1142/ > ----------------------------------------------------------- > > (Updated 2010-10-31 12:45:13) > > > Review request for hbase, stack and Kannan Muthukkaruppan. > > > Summary > ------- > > This patch is from Hairong. Just helping out by putting it up on RB. > > This adds a global, configurable timeout for all HBase RPCs. Uses new config > parameter 'hbase.rpc.timeout' rather than overloading the lease period. > > > This addresses bug HBASE-3154. > http://issues.apache.org/jira/browse/HBASE-3154 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 1029423 > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 1029423 > trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1029423 > trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1029423 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1029423 > > Diff: http://review.cloudera.org/r/1142/diff > > > Testing > ------- > > Not actually sure. I know that we've committed this internally at FB and I > think Hairong did testing on it. > > > Thanks, > > Jonathan > >
