----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1167/#review1804 -----------------------------------------------------------
Ship it! Excellent. Nice and clean. /trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java <http://review.cloudera.org/r/1167/#comment5868> Why a new exception? Why not pass the one that got us here? (Or, maybe there isn't one? Or you can't get at it) - stack On 2010-11-04 11:49:08, Jean-Daniel Cryans wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1167/ > ----------------------------------------------------------- > > (Updated 2010-11-04 11:49:08) > > > Review request for hbase. > > > Summary > ------- > > Changes ZKW to send the SessionExpiredException in the abort call so that > clients can intercept it and reconnect to ZooKeeper by first clearing up > their state and establishing a new connection. > > > This addresses bug HBASE-3095. > http://issues.apache.org/jira/browse/HBASE-3095 > > > Diffs > ----- > > /trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 1030759 > > /trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java > 1030759 > /trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java 1030759 > > Diff: http://review.cloudera.org/r/1167/diff > > > Testing > ------- > > Adapted the client session expiration unit test. > > > Thanks, > > Jean-Daniel > >
