----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1186/#review1833 -----------------------------------------------------------
Ship it! Looks great. trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java <http://review.cloudera.org/r/1186/#comment5933> Add to log the type of bulk assign. trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java <http://review.cloudera.org/r/1186/#comment5934> This is ok for first cut. Later here we should favor servers who are 'new' or not mentioned in .META.. - stack On 2010-11-06 14:38:34, Jonathan Gray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1186/ > ----------------------------------------------------------- > > (Updated 2010-11-06 14:38:34) > > > Review request for hbase, stack and khemani. > > > Summary > ------- > > Adds a configuration option (default true in this patch) for retaining > assignment on startup. If true, initial assignment plan attempts to use > existing assignment info from META (we don't delete assignment info in META > when RS closes region). > > Also changes initial assignment to skip regions from disabled tables rather > than looking at offline flag. > > > This addresses bug HBASE-2896. > http://issues.apache.org/jira/browse/HBASE-2896 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 1032133 > trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java > 1032133 > trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java > 1032133 > trunk/src/test/java/org/apache/hadoop/hbase/master/TestLoadBalancer.java > 1032133 > > Diff: http://review.cloudera.org/r/1186/diff > > > Testing > ------- > > I will write a new unit test of the load balancing method to make sure it > does what is expected. > > I could write a cluster-level TestRetainAssignment test which actually tests > it works end to end but I'm not sure it's necessary. Could also add some > modification to TestClusterRestart or whatever that one is. > > > Thanks, > > Jonathan > >
