----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1176/#review1855 -----------------------------------------------------------
trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java <http://review.cloudera.org/r/1176/#comment6033> people can selective not catch IE and then let their regular abort do it's job. trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.cloudera.org/r/1176/#comment6034> yes, absolutely, because at the end we check every single entry in the results[] and if there are any failures (null, Throwable instances) we throw an exception. So one can be sure that everything is a Result during success, and if you get an exception you have the Throwable handy dandy in both the results array and in thrown exception. trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java <http://review.cloudera.org/r/1176/#comment6035> this is a brand new method, never was in any previous 0.89 DR even. trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java <http://review.cloudera.org/r/1176/#comment6036> it could be either a Throwable or a Result. batch() shouldn't throw many exceptions, they should be identified and lined up with each index entry. trunk/src/test/java/org/apache/hadoop/hbase/client/MultiResponseTest.java <http://review.cloudera.org/r/1176/#comment6037> I blame SVN! It was including my scratch work :-) - Ryan On 2010-11-05 01:43:22, Ryan Rawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1176/ > ----------------------------------------------------------- > > (Updated 2010-11-05 01:43:22) > > > Review request for hbase. > > > Summary > ------- > > This is a change to batch() that substantially increases the error handling. > Included is a new Exception type with a lot more details of what failed and > where. Users will be able to also query the thrown exception to see if there > is a possible cluster problem. They will be able to log the server addresses > that had issues. > > The TestMultiParallel test case passes, I need to run the rest. > > > This addresses bug HBASE-2898. > http://issues.apache.org/jira/browse/HBASE-2898 > > > Diffs > ----- > > trunk/pom.xml 1031470 > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java 1031470 > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 1031470 > trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java 1031470 > trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java > 1031470 > trunk/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java > 1031470 > > trunk/src/main/java/org/apache/hadoop/hbase/client/RetriesExhaustedWithDetailsException.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 1031470 > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerStoppedException.java > 1031470 > trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java > 1031470 > trunk/src/test/java/org/apache/hadoop/hbase/client/MultiResponseTest.java > PRE-CREATION > trunk/src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java > 1031470 > > Diff: http://review.cloudera.org/r/1176/diff > > > Testing > ------- > > > Thanks, > > Ryan > >
