> On 2010-11-08 20:48:32, stack wrote: > > Meant to say I'm +1 on this.
Also, also meant to say that you are getting good at using this Reflection stuff Gary. - stack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1184/#review1857 ----------------------------------------------------------- On 2010-11-08 17:18:26, Gary Helmling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1184/ > ----------------------------------------------------------- > > (Updated 2010-11-08 17:18:26) > > > Review request for hbase. > > > Summary > ------- > > Adds a wrapper class, org.apache.hadoop.hbase.security.User, around > org.apache.hadoop.security.UserGroupInformation, to accommodate the divergent > APIs of both regular Hadoop 0.20, and secure Hadoop 0.20 (which should also > mean 0.21 and later, though I haven't specifically tested that). > > Common methods in both UserGroupInformation versions are invoked directly. > Version specific methods are invoked using reflection. Almost all of the > usage is around testing code that spins up local clusters, since those are > the only parts that exercise UserGroupInformation currently. > > > This addresses bug HBASE-3194. > http://issues.apache.org/jira/browse/HBASE-3194 > > > Diffs > ----- > > src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 9267679 > src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java e4c356d > src/main/java/org/apache/hadoop/hbase/security/User.java PRE-CREATION > src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 83ceac9 > src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 8f9c88f > src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java d436e2e > src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java > b9902f1 > src/test/java/org/apache/hadoop/hbase/security/TestUser.java PRE-CREATION > > Diff: http://review.cloudera.org/r/1184/diff > > > Testing > ------- > > Ran full test suite with these changes against both Hadoop 0.20-append and > yahoo-0.20.104-append (security+append). The only failures match what I'm > currently seeing in trunk. Will remerge from trunk and test against as soon > as it's back to passing. > > Though this is only testing compatibility with both versions with a rebuild. > I still need to test building against 0.20-append then spinning up HBase > using security. Will do that next, just wanted to get some eyes on this to > validate the approach. > > [Update 11/8/2010]: I did some further testing. Compiled HBase against > 0.20-append. Ran YCSB with the compiled HBase against Hadoop 0.20.2 and > yahoo-0.20.104-append (updating just the hadoop jar), to verify the patch > will work against both without rebuilding. YCSB load and varied workloads > completed without any errors. > > > Thanks, > > Gary > >
