----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1209/#review1905 -----------------------------------------------------------
Ship it! This looks like nice utility. - stack On 2010-11-10 17:19:33, Nicolas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1209/ > ----------------------------------------------------------- > > (Updated 2010-11-10 17:19:33) > > > Review request for hbase. > > > Summary > ------- > > bin/hbase VersionInfo is a great existing utility to provide version info > about Hbase jar files. Unfortunately, there is no way to currently get this > information for the running process. For this jira, add an easy/quick way to > see verify the rev of the running jar. > We got recently bit internally because our running jar was a different > version from the jar that we had recently pushed and caused havoc on our > cluster. This problem is more important to fix now that we have rolling > upgrades and will regularly have cluster scenarios with mixed-version RSs. > > > This addresses bug HBASE-3223. > http://issues.apache.org/jira/browse/HBASE-3223 > > > Diffs > ----- > > > trunk/src/main/java/org/apache/hadoop/hbase/master/metrics/MasterMetrics.java > 1033788 > trunk/src/main/java/org/apache/hadoop/hbase/metrics/HBaseInfo.java > PRE-CREATION > trunk/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java > 1033788 > trunk/src/main/java/org/apache/hadoop/hbase/metrics/MetricsString.java > PRE-CREATION > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java > 1033788 > > Diff: http://review.cloudera.org/r/1209/diff > > > Testing > ------- > > loaded on dev cluster and verified that we this was exported via JMX > > > Thanks, > > Nicolas > >
