> On 2010-11-22 17:29:45, Nicolas wrote: > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java, line > > 739 > > <http://review.cloudera.org/r/1212/diff/1/?file=17170#file17170line739> > > > > I'd suggest keeping the store name in this debug message since we're > > considering thread pools for compactions...
Won't the store name be part of the path on the next line when we do sf.toString() where sf is the file we're compacting all into? - stack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1212/#review1971 ----------------------------------------------------------- On 2010-11-11 09:26:47, stack wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1212/ > ----------------------------------------------------------- > > (Updated 2010-11-11 09:26:47) > > > Review request for hbase, Jean-Daniel Cryans and Jonathan Gray. > > > Summary > ------- > > Removed redundancy, corrected some of the english in log messages, changed at > least one to DEBUG. > > > This addresses bug hbase-3227. > http://issues.apache.org/jira/browse/hbase-3227 > > > Diffs > ----- > > trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java > 1033977 > > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java > 1033977 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > 1033979 > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 1033977 > > Diff: http://review.cloudera.org/r/1212/diff > > > Testing > ------- > > > Thanks, > > stack > >
