----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1259/#review2004 -----------------------------------------------------------
Ship it! branches/0.90/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java <http://review.cloudera.org/r/1259/#comment6320> You can make this private now that its no longer referenced by Master? - stack On 2010-11-29 11:04:33, Jonathan Gray wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.cloudera.org/r/1259/ > ----------------------------------------------------------- > > (Updated 2010-11-29 11:04:33) > > > Review request for hbase and stack. > > > Summary > ------- > > We currently let go of dead servers once we finish their shutdown. We should > hang on to them longer to deal with things like network partitions. > > I'm not a fan of SoftReferences so I decided on another approach. > DeadServers now has a maximum number of servers to hold on to in the set > (default 100). Once it reaches the max, it evicts the oldest. > > More code than I had hoped but nothing too crazy. > > > This addresses bug HBASE-3282. > http://issues.apache.org/jira/browse/HBASE-3282 > > > Diffs > ----- > > branches/0.90/src/main/java/org/apache/hadoop/hbase/master/DeadServer.java > 1040221 > branches/0.90/src/main/java/org/apache/hadoop/hbase/master/HMaster.java > 1040221 > > branches/0.90/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java > 1040221 > > branches/0.90/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java > 1040221 > > Diff: http://review.cloudera.org/r/1259/diff > > > Testing > ------- > > Running unit tests now. > > > Thanks, > > Jonathan > >
