-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1414/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
The patch allows alternate HRegionServer subclasses (and in the future
coprocessors) to access HBaseRpcMetrics in order to register additional RPC
methods into the metrics registry.
The changes are:
* add getRpcMetrics() to HBaseServer to allow access to the HBaseRpcMetrics
instance
* add getRpcMetrics() to RegionServerServices (and HRegionServer) to allow for
future coprocessor accounting
* add HBaseRpcMetrics.createMetrics(Class[], boolean) overload -- if boolean
is true, the registered method names will be prefixed with the class name.
This should help clarify origin for custom metrics and help prevent collisions.
This addresses bug HBASE-3405.
http://issues.apache.org/jira/browse/HBASE-3405
Diffs
-----
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 19dbf2b
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 867a059
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java d7147b5
src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerServices.java
1309f93
src/test/java/org/apache/hadoop/hbase/regionserver/TestRpcMetrics.java
PRE-CREATION
Diff: http://review.cloudera.org/r/1414/diff
Testing
-------
Created new org.apache.hadoop.hbase.regionserver.TestRpcMetrics test case to
verify registration and incrementing of metrics from HRegionServer subclasses.
Thanks,
Gary
