Thanks Ted. I will include this build phase patch with the rpm/deb packaging patch. :)
Regards, Eric On 2/17/11 12:58 PM, "Ted Dunning" <[email protected]> wrote: Attaching the packaging to the normal life cycle step is a great idea. Having the packaging to RPM and deb packaging all in one step is very nice. On Thu, Feb 17, 2011 at 12:40 PM, Eric Yang <[email protected]> wrote: Sorry the attachment didn't make it through the mailing list. The patch looks like this: Index: pom.xml =================================================================== --- pom.xml (revision 1071461) +++ pom.xml (working copy) @@ -321,6 +321,15 @@ <descriptor>src/assembly/all.xml</descriptor> </descriptors> </configuration> + <executions> + <execution> + <id>tarball</id> + <phase>package</phase> + <goals> + <goal>single</goal> + </goals> + </execution> + </executions> </plugin> <!-- Run with -Dmaven.test.skip.exec=true to build -tests.jar without running tests (this is needed for upstream projects whose tests need this jar simply for compilation)--> @@ -329,6 +338,7 @@ <artifactId>maven-jar-plugin</artifactId> <executions> <execution> + <phase>prepare-package</phase> <goals> <goal>test-jar</goal> </goals> @@ -355,7 +365,7 @@ <executions> <execution> <id>attach-sources</id> - <phase>package</phase> + <phase>prepare-package</phase> <goals> <goal>jar-no-fork</goal> </goals> On 2/17/11 12:30 PM, "Eric Yang" <[email protected]> wrote: > Hi Stack, > > Thanks for the pointer. This is very useful. What do you think about > making jar file creation to prepare-package phase, and having > assembly:single be part of package phase? This would make room for running > both rpm plugin and jdeb plugin in the packaging phase. Enclosed patch can > express my meaning better. User can run: > > mvn -DskipTests package > > The result would be jars, tarball, rpm, debian packages in target directory. > > Another approach is to use -P rpm,deb to control package type generation. > > The current assumption is to leave hbase bundled zookeeper outside of the > rpm/deb package to improve project integrations. There will be a submodule > called hbase-conf-pseudo package, which deploys a single node hbase cluster > on top of Hadoop+Zookeeper rpms. Would this work for you? > > Regards, > Eric > > On 2/17/11 11:41 AM, "Stack" <[email protected]> wrote: > >> On Thu, Feb 17, 2011 at 11:34 AM, Eric Yang <[email protected]> wrote: >>> Hi, >>> >>> I am trying to understand the release package process for HBase. In the >>> current maven pom.xml, I don't see tarball generation as part of the >>> packaging phase. >> >> The assembly plugin does it for us. Run: >> >> $ mvn assembly:assembly >> >> or >> >> $ mvn -DskipTests assembly:assembly >> >> ... to skip the running of the test suite (1 hour). >> >> See http://wiki.apache.org/hadoop/Hbase/MavenPrimer. >> >> >> >>> What about having a inline process which creates both release tarball, rpm, >>> and debian packages? This is to collect feedback for HADOOP-6255 to ensure >>> HBase integrates well with rest of the stack. Thanks >>> >> >> >> This sounds great Eric. Let us know how we can help. It looks like >> there is an rpm plugin for maven but I've not played with it in the >> past. If you have input on this, and you'd like me to mess with it, >> I'd be happy to help out. >> >> Good stuff, >> St.Ack >> > >
