That sounds sensible Lars. Should be easy enough figuring if you've broken something if you remove the line. St.Ack
On Tue, May 17, 2011 at 11:36 PM, Lars George <[email protected]> wrote: > Hi, > > From RegionServerMetrics.doUpdtaes(): > > ... > // has the extended period for long-living stats elapsed? > if (this.extendedPeriod > 0 && > this.lastUpdate - this.lastExtUpdate >= this.extendedPeriod) { > this.lastExtUpdate = this.lastUpdate; > this.compactionTime.resetMinMaxAvg(); > this.compactionSize.resetMinMaxAvg(); > this.flushTime.resetMinMaxAvg(); > this.flushSize.resetMinMaxAvg(); > this.resetAllMinMax(); > } > ... > > Why do we call resetAllMinMax() as well? They are not > PersistentMetricsTimeVaryingRate related, so I am just wondering why > they are reset as well, since the next "period" interval is resetting > them anyways, no? > > Lars >
