Committed Ted's patch to branch and trunk. St.Ack
On Mon, May 30, 2011 at 7:11 AM, Ted Yu <[email protected]> wrote: > See https://issues.apache.org/jira/browse/HBASE-3934 > > Thanks Lars > > On Mon, May 30, 2011 at 7:02 AM, Lars George <[email protected]> wrote: > >> Hi, >> >> See below from MemStoreFlusher.java (trunk): >> >> static long getMemStoreLimit(final long max, final float limit, >> final float defaultLimit) { >> if (limit >= 0.9f || limit < 0.1f) { >> LOG.warn("Setting global memstore limit to default of " + defaultLimit >> + >> " because supplied value outside allowed range of 0.1 -> 0.9"); >> } >> return (long)(max * limit); >> } >> >> The log message says it is using defaultLimit, but the code is not. >> Should we fix either? >> >> Lars >> >
