Gary: From your comment in the jira on Sept 23rd, it wasn't clear that you were running test suite. Since I have been involved in the review of 4014, I took the action of integration which was premature.
I think in the future, we should use clear language, especially in the final stages of review. We should indicate whether the +1 comes with running test suite or not. In case of multiple committers on the same JIRA (4455 was reviewed by 5 committers), the person planning on committing should indicate the intention clearly. Thanks Gary. On Sep 24, 2011, at 12:03 PM, Gary Helmling <[email protected]> wrote: >> Since both Gary and Eugene have been working on HBASE-4014 for quite some >> time, I didn't initially question the test cases. >> After integrating the patch for TRUNK, I discovered that >> TestRegionServerCoprocessorExceptionWithAbort failed consistently on Mac >> and >> Linux. So I backed it out. >> I first thought of disabling this particular test but later abandoned that >> idea - if a core test fails, this means the feature may have issue. >> I notified Eugene immediately and he will take a look today. >> >> > Ted, I did say that I would commit this change. But I was still in the > process of verifying the tests, so I was a bit surprised to see that it had > been committed. Running the tests had already uncovered one issue > (HBASE-4472). I understand that maybe I'm taking longer than some might > like -- tests do take a long time to run and I was traveling yesterday. I > do appreciate your follow up, but don't see the need for this patch to have > been rushed. > > And seconding Andy's thought, don't take my word for it working! :) I was > contingent on tests passing, which I still had yet to confirm. Sorry if I > wasn't clear on that. > > I'm happy to see the effort going in to improving our test situation, both > speeding up our current tests and separating out test groups. Props to all > who have been contributing to that. Anything we can do to streamline the > patch verification process will make it easier for all to follow it.
