Hi,
Semantically (at least to me :)) it makes sense to have a flushAllRegions method. The flushAllRegions disguised in flushRegions(null) would be hidden logic. One would expect a NPE or nothing to happen if the parameters is null.More, if the parameter comes null unintentionally, we wouldn't like to flush everything. Cosmin On 1/11/12 8:46 PM, "Akash Ashok" <[email protected]> wrote: >Hi All, >There's a discussion going on HBase-4224 about adding a new method to the >HRegionServer. > >Just to give a brief. The patch to HBase-4224 has 2 methods in >HRegionServers >1. flushRegions(List<HRegionInfo> regions) - which flushes a list of >regions >2. flushAllRegions() - flushes all the regions of the region server > >The decision to be made is whether to have flushAllRegions as a separate >method or make flushRegions itself flush all the regions when the >List<HregionInfo> parameter passed is null. > >Could we have the opinion of the community on this please ? >https://issues.apache.org/jira/browse/HBASE-4224 > >Cheers, >Akash A
