On Wed, Feb 22, 2012 at 9:23 AM, Ted Yu <yuzhih...@gmail.com> wrote: > Benoit's comment is directly related to our practice, especially when we > add new methods which are only called by unit tests.
I didn't dare to say it, but now that you do… :P HBase exposes a TON of implementation details in public APIs. Makes things harder to refactor because you don't know if anyone out there is relying on this method or extending that class. Mocking out things that are hidden is certainly a bit harder than calling into a public API javadoced as "for test only", but if it keeps the APIs clean, then I think it's worthwhile. -- Benoit "tsuna" Sigoure Software Engineer @ www.StumbleUpon.com
